dungba88 commented on code in PR #12758:
URL: https://github.com/apache/lucene/pull/12758#discussion_r1382474566


##########
lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java:
##########
@@ -828,6 +829,26 @@ public void add(IntsRef input, T output) throws 
IOException {
     lastInput.copyInts(input);
   }
 
+  void setEmptyOutput(T v) {
+    if (fst.metadata.emptyOutput != null) {
+      fst.metadata.emptyOutput = fst.outputs.merge(fst.metadata.emptyOutput, 
v);

Review Comment:
   startNode & numBytes cannot be final as well, as they can only be known at 
the end.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to