dungba88 commented on code in PR #12758:
URL: https://github.com/apache/lucene/pull/12758#discussion_r1382472928


##########
lucene/core/src/java/org/apache/lucene/util/fst/FST.java:
##########
@@ -1132,4 +1137,28 @@ public abstract static class BytesReader extends 
DataInput {
     /** Returns true if this reader uses reversed bytes under-the-hood. */
     public abstract boolean reversed();
   }
+
+  /**
+   * Represent the FST metadata
+   *
+   * @param <T> the FST output type
+   */
+  public static class FSTMetadata<T> {

Review Comment:
   > This is public because callers would need to separately write/read the 
FSTMetadata some their sources? The FST bytes can stream append only to disk, 
but the end, the compiler produces the final FSTMetadata which must then be 
stored somewhere?
   
   Yes, users can either save the metadata to disk, or get the metadata object 
directly. There is a way that does not require this: embed the metadata to the 
end of the FST bytes, but that would be a bit too radical?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to