mikemccand commented on code in PR #12748:
URL: https://github.com/apache/lucene/pull/12748#discussion_r1381468008
##########
lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java:
##########
@@ -444,9 +446,15 @@ long addNode(FSTCompiler.UnCompiledNode<T> nodeIn) throws
IOException {
int labelRange = nodeIn.arcs[nodeIn.numArcs - 1].label -
nodeIn.arcs[0].label + 1;
assert labelRange > 0;
- if (shouldExpandNodeWithDirectAddressing(
+ boolean continuousLable = labelRange == nodeIn.numArcs;
Review Comment:
Hmm can we please use the `continuousLabel` spelling instead :) To be
consistent...
##########
lucene/core/src/java/org/apache/lucene/util/fst/FST.java:
##########
@@ -96,6 +96,8 @@ public enum INPUT_TYPE {
*/
static final byte ARCS_FOR_DIRECT_ADDRESSING = 1 << 6;
+ static final byte ARCS_FOR_CONTINUOUS = ARCS_FOR_DIRECT_ADDRESSING +
ARCS_FOR_BINARY_SEARCH;
Review Comment:
Could you add a comment explaining this arc optimization case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
