mikemccand commented on PR #12748: URL: https://github.com/apache/lucene/pull/12748#issuecomment-1792198963
I tested this PR using `IndexToFST` from `luceneutil`. This just tests construction time and final FST size, on all `wikimediumall` unique terms, allowing up to 64 MB RAM while building the FST: `main`: ``` saved FST to "fst.bin": 382070800 bytes; 44.146 sec saved FST to "fst.bin": 382070800 bytes; 43.478 sec ``` PR: ``` saved FST to "fst.bin": 381705016 bytes; 42.616 sec saved FST to "fst.bin": 381705016 bytes; 42.832 sec ``` FST size is a wee bit smaller (~0.1%), and curiously the construction time seems to be faster too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org