rmuir commented on PR #12737: URL: https://github.com/apache/lucene/pull/12737#issuecomment-1788320396
also @uschindler i think you read your own results wrong, you can see the regression with FMA in your case too, same as @dweiss: ``` VectorUtilBenchmark.floatDotProductScalar 1024 thrpt 5 3.206 ± 0.018 ops/us ``` So for the record, I still think this PR does the correct thing and prevents any performance drops for anyone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org