dungba88 commented on code in PR #12738:
URL: https://github.com/apache/lucene/pull/12738#discussion_r1377383960
##########
lucene/core/src/java/org/apache/lucene/util/fst/ReverseBytesReader.java:
##########
@@ -17,7 +17,7 @@
package org.apache.lucene.util.fst;
/** Reads in reverse from a single byte[]. */
-final class ReverseBytesReader extends FST.BytesReader {
+class ReverseBytesReader extends FST.BytesReader {
Review Comment:
Also the finality of the class affecting performance is quite new to me. E.g
in https://www.baeldung.com/java-final-performance it is only reported that
finality of variables would help with performance but not finality of classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
