dungba88 commented on code in PR #12738:
URL: https://github.com/apache/lucene/pull/12738#discussion_r1377364142
##########
lucene/core/src/java/org/apache/lucene/util/fst/ReverseBytesReader.java:
##########
@@ -17,7 +17,7 @@
package org.apache.lucene.util.fst;
/** Reads in reverse from a single byte[]. */
-final class ReverseBytesReader extends FST.BytesReader {
+class ReverseBytesReader extends FST.BytesReader {
Review Comment:
Ah I should have a nocommit here. I had an adhoc RelativeReverseBytesReader
as a quick way to read from the compact ByteBlockPool. Next rev I'll put up a
proper implementation which read from the pool directly (this require
inefficient byte copy to a temporary byte array)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
