mikemccand commented on code in PR #12506:
URL: https://github.com/apache/lucene/pull/12506#discussion_r1375466035
##########
lucene/core/src/java/org/apache/lucene/util/ByteBlockPool.java:
##########
@@ -129,21 +143,22 @@ public ByteBlockPool(Allocator allocator) {
}
/**
- * Resets the pool to its initial state reusing the first buffer and fills
all buffers with <code>
- * 0</code> bytes before they reused or passed to {@link
Allocator#recycleByteBlocks(byte[][],
- * int, int)}. Calling {@link ByteBlockPool#nextBuffer()} is not needed
after reset.
+ * Resets the pool to its initial state, reusing the first buffer and
filling all buffers with
+ * {@code 0} bytes before they are reused or passed to {@link
Review Comment:
+1 to make this cleaner (who zeros). Why does byte slicing even require
pre-zero'd buffers?
Maybe open a follow-on issue for this? This change is already great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
