iverase commented on PR #12506:
URL: https://github.com/apache/lucene/pull/12506#issuecomment-1776973771
I like the introduction of `ByteSlicePool` but I wonder if the naming is
correct as it does not feel a generic slicer class but very tied to the format
used by TermsHashPerField. Just wondering if we can have a more descriptive
name ,(That is one of the reason I kept it inside TermsHashPerField).
In the case we keep this class, let's remove the static method I introduced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
