dungba88 commented on PR #12624: URL: https://github.com/apache/lucene/pull/12624#issuecomment-1778455090
There is one thing that baffled me is that we are writing the metadata, including the numBytes & start node in the beginning of the DataOutput. That means once the FST is completed, we can't write the metadata to the same DataOutput as the main body, we have to write it to a different DataOutput (that's why I added a method to just write the metadata). Wondering if it makes sense to write the metadata on the end of the DataOutput (and also read from the end) instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
