stefanvodita opened a new pull request, #12506: URL: https://github.com/apache/lucene/pull/12506
There are several changes here. The ones that change public API: 1. Slice functionality is moved out from `ByteBlockPool` to its own class. There's probably more we can do here, but separating the slices from the block pool seems like a step in the right direction. 2. There was a comment asking not to modify the buffers array outside `ByteBlockPool`. I've made it private instead and readable through a getter to enforce that. 3. The various `setBytesRef` are consolidated. The offsets they worked with were all ints, so I've changed those that were declared as longs. Functionality changes: 1. Calling `newSlice` with a size larger than a block will throw an exception. 2. Decoding a length larger than the remaining buffer space in `setBytesRef` will trip an assertion. 3. `ramBytesUsage` has become simpler, but produces the same result. Other than that, comments and javadocs are updated or expanded. Addresses #6675. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
