rmuir commented on PR #12694: URL: https://github.com/apache/lucene/pull/12694#issuecomment-1770836409
The number of formats (float, binary) multiplies by the number of functions (dot product, cosine, square), so you aren't just adding one function here, it is 3. And in the future perhaps it equates to 4. And I have struggled very hard to make the existing *6* functions we have perform well. Some of them are just extremely inefficient mathematically. So we absolutely must remove the signed functions to add these unsigned ones, if they are better. We can't just keep exploding the amount of stuff we have to support. I am sure my opinion here will be unpopular, that is ok. I have fought the shit out of these methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
