rmuir commented on PR #12694: URL: https://github.com/apache/lucene/pull/12694#issuecomment-1770813179
> Quantizing within `[0-255]` can reduce error. This doesn't make any sense to me, it is 8 bits either way. But supporting _both_ signed and unsigned is a nonstarter for me, it is too much. So if unsigned is better then remove the signed functions from VectorUtil and their associated vectorized methods completely. Then I'm happy, we still have 6 similarity methods, just they use ZERO_EXTEND_B2I instead of B2I and so on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
