mikemccand commented on PR #12625: URL: https://github.com/apache/lucene/pull/12625#issuecomment-1768710355
> What do you think of making a class like `ByteSlicePool` to separte concerns from other `TermsHashPerField` functionality? This sounds compelling to me. The byte slicing/interleaving is complex enough to be self contained and separated from both `ByteBlockPool` (low level block storage) and `TermsHashPerField` (in-memory postings hash). > Overall, we could do the slices and `BytesRef` in this PR and I'll try to rebase #12506 after or we can try to merge the two PRs now. Hmm it looks like this PR was merged already, so I guess @stefanvodita we should continue your ideas in #12506. Very exciting that two devs are suddenly interesting in improving this complex low level code -- thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
