mikemccand commented on PR #12625: URL: https://github.com/apache/lucene/pull/12625#issuecomment-1753617337
> I run luceneutil for wikimedium10m and I don't think it shows any slow down (I find hard to understand the output): Hmm, surprisingly noisy, especially for the biggest regression and anti-regression. Did this run for the full 20 iterations? Maybe re-run with `wikimediumall`? Actually, sorry, this change should only impact indexing, I think? We only use this (complex) memory store to store interleaved slices of postings lists? I think it's fine to leave this to the nightly benchmarks -- let's watch after pushing if they catch any slowdown. This is otherwise a rote refactoring (separating the logic of packed `BytesRef` from the paged `byte[]` storage). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
