easyice commented on code in PR #12658: URL: https://github.com/apache/lucene/pull/12658#discussion_r1357032536
########## lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java: ########## @@ -1248,7 +1259,8 @@ private void writeIndex( metaOut.writeBytes(maxPackedValue, 0, config.packedIndexBytesLength); metaOut.writeVLong(pointCount); - metaOut.writeVInt(docsSeen.cardinality()); + assert docsSeen != null || docCount != -1; Review Comment: Wow, it is wonderful, thanks for your suggestion! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org