dweiss commented on PR #12650: URL: https://github.com/apache/lucene/pull/12650#issuecomment-1757307273
Oh, impressive work. I'm surprised it's worked because I know there are incompatibilities between palantir's consistent version plugin and newer spotless releases. Overall, it looks great. I would strongly encourage to rewrite patch history a bit though - separate all build-related changes from the google format upgrade. Then apply build changes (one patch), apply google format upgrade (second patch), commit auto-reformatted/ regenerated code (third patch), add the third commit SHA to .git-blame-ignore-revs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
