risdenk commented on code in PR #12650: URL: https://github.com/apache/lucene/pull/12650#discussion_r1353286034
########## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene84/gen_ForUtil.py: ########## @@ -15,7 +15,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -from fractions import gcd +from math import gcd Review Comment: Python 3.5 added `gcd` to `math` and Python 3.9 removed from `fractions` - https://bugs.python.org/issue39350 ########## lucene/core/src/java/org/apache/lucene/codecs/lucene90/gen_ForUtil.py: ########## @@ -15,7 +15,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -from fractions import gcd +from math import gcd Review Comment: Python 3.5 added `gcd` to `math` and Python 3.9 removed from `fractions` - https://bugs.python.org/issue39350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
