gsmiller commented on code in PR #12587:
URL: https://github.com/apache/lucene/pull/12587#discussion_r1352940936


##########
lucene/core/src/java/org/apache/lucene/util/StringSorter.java:
##########
@@ -19,7 +19,11 @@
 
 import java.util.Comparator;
 
-abstract class StringSorter extends Sorter {
+/**
+ * A {@link BytesRef} sorter tries to use a efficient radix sorter if {@link 
StringSorter#cmp} is a
+ * {@link BytesRefComparator}, otherwise fallback to {@link 
StringSorter#fallbackSorter}
+ */
+public abstract class StringSorter extends Sorter {

Review Comment:
   Maybe add `@lucene.internal` now that we're making this public?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to