jpountz commented on issue #12418:
URL: https://github.com/apache/lucene/issues/12418#issuecomment-1742740792
Sorry @Yuti-G I had missed your reply!
I think that reverting the commit that you linked only made the test pass
because this commit adds a call to `random().nextInt()` to
`LuceneTestCase#newIndexWriterConfig()`. So by reverting this commit,
`TestDrillSideways.testRandom()` got a difference sequence of random numbers
for everything after the `newIndexWriterConfig()` call and the particular
configuration that made this test fail was altered.
By the way if I revert the merge-on-refresh commit and then add back the
call to `r.nextInt(3)`, the failure still reproduces:
diff
```
diff --cc
lucene/core/src/test/org/apache/lucene/index/TestLogMergePolicy.java
index 0b00a20a17f,517542699c1..00000000000
--- a/lucene/core/src/test/org/apache/lucene/index/TestLogMergePolicy.java
+++ b/lucene/core/src/test/org/apache/lucene/index/TestLogMergePolicy.java
diff --git
a/lucene/test-framework/src/java/org/apache/lucene/tests/util/LuceneTestCase.java
b/lucene/test-framework/src/java/org/apache/lucene/tests/util/LuceneTestCase.java
index 1a5a876a7b7..d6649a26e9a 100644
---
a/lucene/test-framework/src/java/org/apache/lucene/tests/util/LuceneTestCase.java
+++
b/lucene/test-framework/src/java/org/apache/lucene/tests/util/LuceneTestCase.java
@@ -1037,6 +1037,8 @@ public abstract class LuceneTestCase extends Assert {
c.setIndexWriterEventListener(new MockIndexWriterEventListener());
}
+ r.nextInt(3);
+
c.setMaxFullFlushMergeWaitMillis(rarely() ? atLeast(r, 1000) :
atLeast(r, 200));
return c;
}
```
This looks unrelated to merge-on-refresh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
