shubhamvishu commented on code in PR #12183: URL: https://github.com/apache/lucene/pull/12183#discussion_r1333269792
########## lucene/core/src/java/org/apache/lucene/index/TermStates.java: ########## @@ -211,4 +244,40 @@ public String toString() { return sb.toString(); } + + /** Wrapper over TermState, ordinal value, term doc frequency and total term frequency */ Review Comment: Thanks for explaining and reviewing @uschindler! > Lucene main (Future Lucene 10.x) will use minimum Java 17. branch_9x .... Got it, yes that would be great! I would be happy to open a separate PR dealing with changing all such current classes in lucene into a record class which get us started atleast(I don't know if that should be rather incremental effort though). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org