shubhamvishu commented on code in PR #12183:
URL: https://github.com/apache/lucene/pull/12183#discussion_r1333163431
##########
lucene/core/src/java/org/apache/lucene/index/TermStates.java:
##########
@@ -211,4 +244,40 @@ public String toString() {
return sb.toString();
}
+
+ /** Wrapper over TermState, ordinal value, term doc frequency and total term
frequency */
Review Comment:
Indeed, I didn't use record because I couldn't find any other usages of
`record` in the whole codebase(just 1-2) which convinced me to have a static
class. Is there a minimum JDK that have to be supported for lucene(jdk 11 or
17?)? In
[build.gradle](https://github.com/apache/lucene/blob/main/build.gradle#L76) I
see `minJavaVersion = JavaVersion.VERSION_17` so maybe its fine to use `record`
in the above change? Let me know if I should instead change this to a `record`
or maybe keep it as is. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
