dweiss commented on code in PR #12577:
URL: https://github.com/apache/lucene/pull/12577#discussion_r1332621322
##########
gradle/java/core-mrjar.gradle:
##########
@@ -29,20 +29,19 @@ configure(project(":lucene:core")) {
dependencies.add("main${jdkVersion}Implementation",
sourceSets.main.output)
tasks.named("compileMain${jdkVersion}Java").configure {
- def apijar = new File(apijars, "jdk${jdkVersion}.apijar")
-
- inputs.file(apijar)
+ def apijar =
layout.projectDirectory.file("src/generated/jdk/jdk${jdkVersion}.apijar")
Review Comment:
Oh, sorry - I thought you'd just replace the string with
"${apijars}/jdk${jdkVersion}/.apijar" but I see how this can defeat the purpose
of having project-relative paths (if it's a File and resolves to a full path,
for example).
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
