tylerbertrand commented on code in PR #12577:
URL: https://github.com/apache/lucene/pull/12577#discussion_r1332210752
##########
gradle/java/core-mrjar.gradle:
##########
@@ -29,20 +29,19 @@ configure(project(":lucene:core")) {
dependencies.add("main${jdkVersion}Implementation",
sourceSets.main.output)
tasks.named("compileMain${jdkVersion}Java").configure {
- def apijar = new File(apijars, "jdk${jdkVersion}.apijar")
-
- inputs.file(apijar)
+ def apijar =
layout.projectDirectory.file("src/generated/jdk/jdk${jdkVersion}.apijar")
Review Comment:
Sort of - the lazy file API (`RegularFile` in this case) doesn't mix well
with the normal, "eager" `File` type. Since other things use `apijars`, I
didn't want to have these changes cascade elsewhere in the project by updating
that to use the lazy file API. Turns out that was a simple update to make, so
I've just pushed a commit making that update, and now the path of `apijar` is
relative to the `apijars` variable once again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
