LuXugang commented on PR #12405:
URL: https://github.com/apache/lucene/pull/12405#issuecomment-1633954140
Thanks for providing excellent advice.
> isMissingValueCompetitive() should return false if the missing value is
equal to the bottom value and the pruning is SKIP_MORE
addressed in
[4a72bf6](https://github.com/apache/lucene/pull/12405/commits/4a72bf6d8741ee779f16c3f403bd01cbbdf49bbe)
and
[94d560c](https://github.com/apache/lucene/pull/12405/commits/94d560c061c76c4c14732d4bff75a920b9f1e97b)
> The competitive iterator can better tune the min/max values. For instance
currently, if the bottom value is 5 and the sort is ascending, we'll use a
range on [MIN_VALUE, 5] to filter competitive hits. But with SKIP_MORE, we
could now make it [MIN_VALUE, 4]. FYI we have NumericUtils#(add|subtract) to
add/subtract on binary representations of numbers.
addressed in
[4d50317](https://github.com/apache/lucene/pull/12405/commits/4d503171e5316a5f14597f57cb0626ed62759fba)
and
[416c333](https://github.com/apache/lucene/pull/12405/commits/416c33325b73348c8dd962bbed69d6f13f18b8df)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
