benwtrent commented on code in PR #12434: URL: https://github.com/apache/lucene/pull/12434#discussion_r1269794542
########## lucene/core/src/java/org/apache/lucene/util/hnsw/KnnResultsProvider.java: ########## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.lucene.util.hnsw; + +/** knn results provider */ +public interface KnnResultsProvider { + KnnResults getKnnResults(IntToIntFunction vectorToOrd); Review Comment: > This vectorToOrd argument feels specific to the current implementation. Could the API work on doc IDs? Even regular TopK needs access to the ordinal->docId transformation because the vector storage could be sparse and eagerly transforming ordinal->docId would add unnecessary overhead. TopK only needs to do the transformation from ordinal->docId when it builds the topdocs result set. ToParentJoin needs the docId to compare against the parent bitset. I can see if there is a better way to get the ord->doc transformation into ToParentJoin without hurting sparse vector search performance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
