shubhamvishu commented on PR #12183:
URL: https://github.com/apache/lucene/pull/12183#issuecomment-1631040694

   >  I suspected that there would be cases when we would fork from the 
executor into itself, which causes deadlocks
   
   I see , thanks for the explanation @jpountz !
   
   > Now that createWeight() can fork tasks into the executor, we should never 
call createWeight() from one of the tasks that get created for each 
IndexSearcher slice.
   
   I'm not sure how we can achieve or enforce this. Is it possible to solve 
this problem somehow?
   
   > AssertingCollector is the problem in this particular case.
   
   Not sure if I completely understood this. Is it because it eventually calls 
`ExplanationAsserter#collect` which then calls `IndexSearcher.explain` and 
`#createWeight` right?
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to