shubhamvishu commented on PR #12183: URL: https://github.com/apache/lucene/pull/12183#issuecomment-1630275732
@jpountz As I was running the tests(`./gradlew test`) with this PR I observed it getting stuck on `TestPayloadCheckQuery` or `TestBasics` a couple of times intermittently. Looking into it, it seemed some threads were parked for indefinite time and were never unparked causing it to stuck when the searcher has been passed an executor. I was able to get the tests working by increasing the `threads` below to atleast **13**(i.e. setting pool size and max pool size to minimum 13) for the `searcher` used in these tests. Should we override the passed executor for these tests? but looks like its not right to do so to me. Maybe we should not set it to `>8` which is the maximum currently(and I think it depends on the no. of cores available)? Let me know what do you think? https://github.com/apache/lucene/blob/main/lucene/test-framework/src/java/org/apache/lucene/tests/util/LuceneTestCase.java#L1946-L1954 ``` threads = TestUtil.nextInt(random, 1, 8); ex = new ThreadPoolExecutor( threads, threads, 0L, TimeUnit.MILLISECONDS, new LinkedBlockingQueue<Runnable>(), new NamedThreadFactory("LuceneTestCase")); ``` #### To reproduce ``` gradlew test --tests TestPayloadCheckQuery.testInequalityPayloadChecks -Dtests.seed=8C15E6548CE0251F gradlew test --tests TestBasics.testSpanNearExact -Dtests.seed=736DA8E94FF33AD0 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
