uschindler commented on issue #12396: URL: https://github.com/apache/lucene/issues/12396#issuecomment-1617754157
The framework to plug in in custom formats into `org.apache.lucene.internal.vectorization` was merged, so stage is open to implement something. Hints: - Both the scalar and the vectorized implementation need to be moved to that package and share a common interface. - A getter needs to be added to VectorizationProvider to return a singleton (if stateless) or an instance (if stateful like `ForUtil`, like `newForUtil98()` for the Lucene 9.8 codec). - The calling class that gets the provider needs to be added for caller sensitive checks to prevent misuse. - A test comparing both impementations with random data extending from BaseVectorizationTestCase. I can mock it up for ForUtil (looks simple, just a bit copy-paste and defining interface) and replacing `new ForUtil()` by `VectorizationProvider.getInstance().newForUtil98()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
