easyice commented on code in PR #12381:
URL: https://github.com/apache/lucene/pull/12381#discussion_r1247416965
##########
lucene/core/src/java/org/apache/lucene/index/NumericDocValuesWriter.java:
##########
@@ -234,10 +246,41 @@ public long cost() {
static class NumericDVs {
private final long[] values;
private final BitSet docsWithField;
+ private final int maxDoc;
NumericDVs(long[] values, BitSet docsWithField) {
this.values = values;
this.docsWithField = docsWithField;
+ this.maxDoc = values.length;
+ }
+
+ int maxDoc() {
+ return maxDoc;
+ }
+
+ private boolean advanceExact(int target) {
+ if (docsWithField != null) {
+ return docsWithField.get(target);
+ }
+ return true;
+ }
+
+ private int advance(int target) {
+ if (docsWithField != null) {
+ return docsWithField.nextSetBit(target);
+ }
+
+ if (target < maxDoc) {
+ return target;
+ }
+ return DocIdSetIterator.NO_MORE_DOCS;
Review Comment:
Nice catch, it's updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
