easyice commented on code in PR #12381:
URL: https://github.com/apache/lucene/pull/12381#discussion_r1246457143
##########
lucene/core/src/java/org/apache/lucene/util/BitSet.java:
##########
@@ -111,4 +111,70 @@ public void or(DocIdSetIterator iter) throws IOException {
set(doc);
}
}
+
+ public static final BitSet all(int maxDoc) {
Review Comment:
great suggestion! i tested earlier the virtual function can be inline
always if there are only 2 implementations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
