jpountz commented on PR #12382:
URL: https://github.com/apache/lucene/pull/12382#issuecomment-1604019215

   The speedup is not as high as I had hoped, so I'm leaning towards not 
merging this PR. Maybe someone figures out how to make this code run faster!
   
   ```
                               TaskQPS baseline      StdDevQPS 
my_modified_version      StdDev                Pct diff p-value
                         TermDTSort      183.14      (1.6%)      179.82      
(5.1%)   -1.8% (  -8% -    5%) 0.133
                             IntNRQ      105.92     (15.4%)      104.00     
(13.4%)   -1.8% ( -26% -   32%) 0.693
              HighTermDayOfYearSort      436.32      (1.8%)      428.70      
(5.8%)   -1.7% (  -9% -    6%) 0.203
                  HighTermTitleSort      151.24      (6.0%)      148.87      
(8.8%)   -1.6% ( -15% -   14%) 0.512
                         AndHighLow     1692.56      (3.7%)     1666.70      
(2.8%)   -1.5% (  -7% -    5%) 0.140
        BrowseRandomLabelSSDVFacets       14.89      (8.3%)       14.75      
(6.4%)   -0.9% ( -14% -   14%) 0.685
              BrowseMonthTaxoFacets       30.24      (6.9%)       29.95      
(8.3%)   -0.9% ( -15% -   15%) 0.698
                         OrHighHigh       47.35      (6.6%)       46.96      
(4.2%)   -0.8% ( -10% -   10%) 0.630
                           Wildcard      220.59      (4.7%)      218.79      
(4.4%)   -0.8% (  -9% -    8%) 0.570
          BrowseDayOfYearTaxoFacets       45.10      (3.5%)       44.82      
(2.7%)   -0.6% (  -6% -    5%) 0.525
                          OrHighLow      650.91      (4.4%)      647.28      
(3.1%)   -0.6% (  -7% -    7%) 0.646
               HighTermTitleBDVSort       25.83      (1.7%)       25.70      
(3.6%)   -0.5% (  -5% -    4%) 0.575
                          OrHighMed      167.05      (5.0%)      166.32      
(3.6%)   -0.4% (  -8% -    8%) 0.752
                MedIntervalsOrdered       17.59      (3.5%)       17.53      
(4.1%)   -0.4% (  -7% -    7%) 0.758
                         AndHighMed      391.35      (4.4%)      390.02      
(3.7%)   -0.3% (  -8% -    8%) 0.789
                       OrNotHighLow     1442.98      (3.7%)     1438.18      
(3.3%)   -0.3% (  -7% -    7%) 0.767
               BrowseDateTaxoFacets       44.30      (3.0%)       44.19      
(3.0%)   -0.2% (  -6% -    5%) 0.795
                             Fuzzy1      139.23      (1.1%)      138.94      
(1.0%)   -0.2% (  -2% -    1%) 0.539
                             Fuzzy2      112.21      (0.8%)      112.00      
(0.9%)   -0.2% (  -1% -    1%) 0.502
                    MedSloppyPhrase       35.95      (2.2%)       35.90      
(2.1%)   -0.1% (  -4% -    4%) 0.836
                            Respell       95.08      (1.5%)       94.97      
(1.4%)   -0.1% (  -2% -    2%) 0.795
                        MedSpanNear      100.90      (5.9%)      100.89      
(7.0%)   -0.0% ( -12% -   13%) 0.997
                           PKLookup      242.29      (5.0%)      242.27      
(4.2%)   -0.0% (  -8% -    9%) 0.995
                   HighSloppyPhrase       24.75      (3.2%)       24.75      
(4.6%)   -0.0% (  -7% -    8%) 0.997
                LowIntervalsOrdered       13.76      (4.3%)       13.77      
(4.2%)    0.0% (  -8% -    8%) 0.976
             OrHighMedDayTaxoFacets       17.13      (4.5%)       17.14      
(3.6%)    0.1% (  -7% -    8%) 0.937
          BrowseDayOfYearSSDVFacets       20.81     (13.8%)       20.83     
(13.5%)    0.1% ( -23% -   31%) 0.980
                            Prefix3      249.54      (5.3%)      250.06      
(2.6%)    0.2% (  -7% -    8%) 0.875
                        LowSpanNear       51.89      (2.1%)       52.03      
(2.7%)    0.3% (  -4% -    5%) 0.740
                       HighSpanNear       30.44      (4.2%)       30.54      
(5.2%)    0.3% (  -8% -   10%) 0.841
                       OrNotHighMed      435.83      (6.3%)      437.24      
(5.3%)    0.3% ( -10% -   12%) 0.860
               BrowseDateSSDVFacets        5.52      (7.9%)        5.54     
(10.2%)    0.4% ( -16% -   20%) 0.894
                      OrHighNotHigh      332.17      (7.0%)      333.72      
(6.0%)    0.5% ( -11% -   14%) 0.821
                            LowTerm      852.62      (6.5%)      856.98      
(5.7%)    0.5% ( -10% -   13%) 0.791
                    LowSloppyPhrase       34.09      (4.2%)       34.28      
(3.8%)    0.6% (  -7% -    8%) 0.654
                       OrHighNotMed      389.58      (7.0%)      392.08      
(6.6%)    0.6% ( -12% -   15%) 0.765
               HighIntervalsOrdered       16.82      (5.4%)       16.93      
(7.3%)    0.6% ( -11% -   14%) 0.750
                       OrHighNotLow      503.57      (7.5%)      507.57      
(6.6%)    0.8% ( -12% -   16%) 0.721
                            MedTerm      954.20      (8.0%)      962.60      
(6.3%)    0.9% ( -12% -   16%) 0.699
                      OrNotHighHigh      483.09      (6.5%)      487.85      
(5.4%)    1.0% ( -10% -   13%) 0.601
              BrowseMonthSSDVFacets       21.00      (9.5%)       21.25     
(10.3%)    1.2% ( -16% -   23%) 0.697
            AndHighMedDayTaxoFacets       20.84      (2.6%)       21.18      
(2.9%)    1.6% (  -3% -    7%) 0.060
           AndHighHighDayTaxoFacets       28.62      (2.1%)       29.09      
(2.3%)    1.6% (  -2% -    6%) 0.018
                         HighPhrase      211.10      (4.2%)      214.68      
(3.3%)    1.7% (  -5% -    9%) 0.154
                           HighTerm      380.81      (8.8%)      387.70      
(6.9%)    1.8% ( -12% -   19%) 0.472
                          MedPhrase       22.08      (4.8%)       22.48      
(3.8%)    1.8% (  -6% -   10%) 0.180
               MedTermDayTaxoFacets       80.33      (3.1%)       81.88      
(2.7%)    1.9% (  -3% -    7%) 0.036
                          LowPhrase      348.19      (3.5%)      355.21      
(2.9%)    2.0% (  -4% -    8%) 0.048
                  HighTermMonthSort     3789.19      (4.2%)     3879.83      
(3.0%)    2.4% (  -4% -   10%) 0.039
        BrowseRandomLabelTaxoFacets       35.61      (6.2%)       36.77      
(2.3%)    3.3% (  -4% -   12%) 0.028
                        AndHighHigh       51.92      (5.9%)       54.91      
(5.0%)    5.7% (  -4% -   17%) 0.001
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to