jpountz commented on code in PR #12382: URL: https://github.com/apache/lucene/pull/12382#discussion_r1333140455
########## lucene/core/src/java/org/apache/lucene/search/BlockMaxConjunctionBulkScorer.java: ########## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.search; + +import java.io.IOException; +import java.util.Arrays; +import java.util.Comparator; +import java.util.List; +import org.apache.lucene.search.Weight.DefaultBulkScorer; +import org.apache.lucene.util.Bits; +import org.apache.lucene.util.MathUtil; + +/** + * BulkScorer implementation of {@link BlockMaxConjunctionScorer} that focuses on top-level + * conjunctions over clauses that do not have two-phase iterators. Use a {@link DefaultBulkScorer} + * around a {@link BlockMaxConjunctionScorer} if you need two-phase support. + * Another difference with {@link BlockMaxConjunctionScorer} is that this scorer computes scores on + * the fly in order to be able to skip evaluating more clauses if the total score would be under the + * minimum competitive score anyway. This generally works well because computing a score is cheaper + * than Review Comment: Oops yes, I have a fix locally that I haven't uploaded yet, will do shortly. The sentence is "This generally works well because computing a score is cheaper than decoding a block of postings". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
