jainankitk commented on issue #12297: URL: https://github.com/apache/lucene/issues/12297#issuecomment-1595083334
> I agree with Robert that 1kB per segment doesn't sound like a crazy amount of allocations, which suggests that you are searching many segments. Does the memory allocation profile look much better after your change? I agree that per segment it isn't huge but those allocations add up to couple of GBs. And I did notice that the float[] did not show up in the allocation profile after applying above patch > If yes, I wouldn't be against a small isolated change that avoids these allocations. It looks like one way to do it would be to update the TermWeight constructor to assign a dummy simScorer when scores are not needed. I was thinking along similar lines. @sgup432 will be raising PR for making this change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
