atris commented on issue #12347: URL: https://github.com/apache/lucene/issues/12347#issuecomment-1591837122
> > Take the LeafSlice[] in constructor to allow for custom slice computation. > > Sounds good, I'll happily review that change. > > > Discuss different options to customize SliceExecutor or we will want to replace it with some other interface > > Ok to discussing, I do think that making things pluggable is a change that's difficult to revert in terms of backwards compatibility, and I think we should put some effort into changing the current behaviour before we add new public abstractions. Strong -1 t replacing the interface. I think it has worked well for many users for a while and it would be breaking back compatibility to serve a specific use case. I am just catching up on this thread -- why does the current SliceExecutor not work for extension in this case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
