javanna commented on issue #12347: URL: https://github.com/apache/lucene/issues/12347#issuecomment-1584232374
I agree that we should either have the executor or the slice executor configurable. On fixing the slice executor without making it configurable, my guts feeling is that it is going to be difficult to guarantee default behaviour that is good for all the consumers. I agree that executing slices on either the caller thread or the executor makes it difficult to reason about what happens where and to appropriately size thread pools. Though to have a clear distinction between a coordinator thread pool and a collection thread pool, sequential execution should also be offloaded to the executor which is somehow controversial. I am a bit nervous about making this the default, hence the thought on exposing a `SliceExecutor` abstraction that is configurable and can make these decisions. Could it be an idea to move some portions of `IndexSearcher#search(Query, CollectorManager)` to the `SliceExecutor` itself, for it to deal with task creation and execution as a whole? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
