clayburn commented on code in PR #12293:
URL: https://github.com/apache/lucene/pull/12293#discussion_r1200469331


##########
gradle/ge.gradle:
##########
@@ -0,0 +1,26 @@
+def isGithubActions = System.getenv('GITHUB_ACTIONS') != null
+def isJenkins = System.getenv('JENKINS_URL') != null
+def isCI = isGithubActions || isJenkins
+
+gradleEnterprise {
+    server = "https://ge.apache.org";
+    buildScan {
+        capture { taskInputFiles = true }
+        uploadInBackground = !isCI
+        publishAlways()
+        publishIfAuthenticated()
+        obfuscation {
+            ipAddresses { addresses -> addresses.collect { address -> 
"0.0.0.0"} }
+        }
+    }
+}
+
+buildCache {

Review Comment:
   This configuration will only be applied if your build sets 
`org.gradle.caching=true`. As the Lucene build works today, you do not set 
this, so caching as a feature will be globally disabled. If a user enables 
caching, then this configuration would be applied. I'd recommend leaving this 
so that these settings get applied when users do enable the global caching 
property.
   
   Aside from that, what is the objection to using build caching? Is it due to 
disk space considerations as stated in the gradle properties template?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to