MarcusSorealheis commented on code in PR #12235:
URL: https://github.com/apache/lucene/pull/12235#discussion_r1178293476
##########
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java:
##########
@@ -306,7 +308,7 @@ private void addDiverseNeighbors(int level, int node,
NeighborQueue candidates)
for (int i = 0; i < size; i++) {
int nbr = neighbors.node[i];
NeighborArray nbrNbr = hnsw.getNeighbors(level, nbr);
- nbrNbr.insertSorted(node, neighbors.score[i]);
+ nbrNbr.addOutOfOrder(node, neighbors.score[i]);
Review Comment:
Is the change unneeded in the Lucene90 file if it's changed here? I was
thinking we could rename `nbrNbr` wherever it is used because it is confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
