zhaih commented on PR #12235: URL: https://github.com/apache/lucene/pull/12235#issuecomment-1518409710
@msokolov Thanks for your feedback. Indeed the memory consumption is a concern and after I thought it more I found that it might be better to lazily sort the nodes and figure out which nodes are unchecked all at once. In this way we still able to avoid the extra computation at the cost of 1 extra int, which I believe is more or less negligible now. For sure I will do the KnnGraphTester (and thank you for pointing me to there, TBH I haven't done any test with KNN yet...) still to just see whether the performance gain is observable, but let me know whether the latter approach addresses your concern. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
