zhaih commented on code in PR #12208:
URL: https://github.com/apache/lucene/pull/12208#discussion_r1157850839
##########
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/TermAutomatonScorer.java:
##########
@@ -52,6 +52,7 @@ class TermAutomatonScorer extends Scorer {
private int docID = -1;
private int freq;
+ private EnumAndScorer[] enums;
Review Comment:
I think usually it's better to introduce it when we really need it? But if
you insist I'm also OK since it's just another reference.
If you decide to still use a new field then I would suggest:
1. Make it `final`
2. Change the name to `originalSubsOnDoc` or so, since `enums` is a bit
general
3. Add some javadoc explaining it is for explain use.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
