zhaih commented on code in PR #12208: URL: https://github.com/apache/lucene/pull/12208#discussion_r1157730824
########## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/TermAutomatonScorer.java: ########## @@ -345,6 +347,14 @@ private void countMatches() throws IOException { } } + public EnumAndScorer[] getEnums() { Review Comment: package-private? ########## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/TermAutomatonScorer.java: ########## @@ -345,6 +347,14 @@ private void countMatches() throws IOException { } } + public EnumAndScorer[] getEnums() { + return enums; + } + + public LeafSimScorer getLeafSimScorer() { Review Comment: package-private? ########## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/TermAutomatonScorer.java: ########## @@ -52,6 +52,7 @@ class TermAutomatonScorer extends Scorer { private int docID = -1; private int freq; + private EnumAndScorer[] enums; Review Comment: Then are we able to just use `this.subsOnDoc`? Seems that's the one that already filtered out the `null`s? Because we'll anyway filter out the `null` when explain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org