zacharymorn commented on PR #12194: URL: https://github.com/apache/lucene/pull/12194#issuecomment-1474732221
> Sorry for the delayed response, so I saw it in my optimized version of `BitSet#or` that does use the `peekNextNonMatchingDocID` API. I also found the bug, it turns out we just weren't resetting the `lastNonMatchingDoc` in the `reset()` function. I created a [pull request](https://github.com/zacharymorn/lucene/pull/1) with my `BitSet#or` changes and the (one-liner) bug fix. > > I'm also planning on benchmarking this and will post here when I do. Thanks @mdmarshmallow for the PR and benchmark result. I have left a few comments there. I feel the reasons you are not seeing much change from benchmark could be that the implementation in `BitSet#or` might got overridden by subclasses, and/or the implementations in subclasses did not utilize their specialized data structures? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
