uschindler commented on code in PR #12199: URL: https://github.com/apache/lucene/pull/12199#discussion_r1133247211
########## lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThreadPool.java: ########## @@ -130,13 +134,15 @@ private void ensureOpen() { } } + private synchronized boolean contains(DocumentsWriterPerThread state) { + return dwpts.contains(state); + } + void marksAsFreeAndUnlock(DocumentsWriterPerThread state) { final long ramBytesUsed = state.ramBytesUsed(); - synchronized (this) { - assert dwpts.contains(state) - : "we tried to add a DWPT back to the pool but the pool doesn't know aobut this DWPT"; - freeList.add(state, ramBytesUsed); - } + assert contains(state) + : "we tried to add a DWPT back to the pool but the pool doesn't know aobut this DWPT"; Review Comment: typo :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org