dweiss commented on code in PR #12199:
URL: https://github.com/apache/lucene/pull/12199#discussion_r1132739002
##########
lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThreadPool.java:
##########
@@ -113,15 +113,19 @@ private synchronized DocumentsWriterPerThread newWriter()
{
* operation (add/updateDocument).
*/
DocumentsWriterPerThread getAndLock() {
- synchronized (this) {
- ensureOpen();
- DocumentsWriterPerThread dwpt =
freeList.poll(DocumentsWriterPerThread::tryLock);
- if (dwpt == null) {
- dwpt = newWriter();
+ ensureOpen();
+ DocumentsWriterPerThread dwpt =
freeList.poll(DocumentsWriterPerThread::tryLock);
+ if (dwpt == null) {
Review Comment:
No need to convince me, @jpountz - I just expressed my reluctance at it
because, well, it requires convincing. :) Unless there's really a huge gain, I
typically just go with what I understand works (making the field volatile, for
example).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
