gsmiller commented on code in PR #11780: URL: https://github.com/apache/lucene/pull/11780#discussion_r1132608504
########## lucene/facet/src/java/org/apache/lucene/facet/sortedset/SSDVReaderStatesCalculator.java: ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.facet.sortedset; + +import java.io.IOException; +import java.util.List; +import java.util.stream.Collectors; +import org.apache.lucene.facet.FacetsConfig; +import org.apache.lucene.search.IndexSearcher; +import org.apache.lucene.search.ReferenceManager; + +/** + * Get reader states after a refresh. Example call: readerStates = + * searcherManager.maybeRefreshAndReturnState(new SSDVReaderStatesCalculator(), config); + */ +public class SSDVReaderStatesCalculator + implements ReferenceManager.StateCalculator< + List<SortedSetDocValuesReaderState>, IndexSearcher, FacetsConfig> { + + /** No arguments needed */ + public SSDVReaderStatesCalculator() {} + + @Override + public List<SortedSetDocValuesReaderState> calculate(IndexSearcher current, FacetsConfig config) { + return config.getDimConfigs().keySet().stream() Review Comment: One issue here is that the user may have indexed SSDVFacetFields without making any configuration changes (i.e., the default dim config was fine for them). In this case, the dim configs you reference here won't know about the fields. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
