mikemccand commented on PR #12183: URL: https://github.com/apache/lucene/pull/12183#issuecomment-1598718175
I also like the direction this is going! This might be a nice latency reduction for primary key lookups on idle-ish hosts. It is certainly a new use of `IndexSearcher`'s executor -- can we improve the javadocs of that parameter to explain that many more tasks than simply the number of segments/slices might be executed? We don't want callers thinking they can pass in an overly bounded queue size on their executors. Unfortunately, Lucene's nightly benchmarks (`luceneutil`) don't test concurrency within a single query at all -- I opened [this issue](https://github.com/mikemccand/luceneutil/issues/221) to improve the situation. @jpountz also previously opened [this issue](https://github.com/mikemccand/luceneutil/issues/210) to ensure we are exercising that code path too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
