rmuir commented on PR #12141: URL: https://github.com/apache/lucene/pull/12141#issuecomment-1427025395
and please, please, no `PrefixCodedTerms extends X` where X is some new abstraction used. that's wrong and it puts the onus on PrefixCodedTerms to now deliver on some interface for these crappy join queries. Instead, if you add a new X, it can use as its code implementation, PrefixCodedTerms. that way the onus is backwards, on the join stuff to implement its own interface. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
