uschindler commented on PR #12141: URL: https://github.com/apache/lucene/pull/12141#issuecomment-1426666265
I am still not happy with this idea at all, because next to sorting we still build the PrefixCodedTerms instance 2 times on construction. I think the original idea of @gsmiller is good and in combination with It would be good to find a way to share the PrefixCodedTerms instance between both queries (also for memory usage). The problem is that both queries (TermInSet and SortedDocValuesSetQuery) live in different packages. If both would be in same package we could make a "pkg private" ctor vor both so they can share their PrefixCodedTerms without making it public. My idea would be to have TermInSetQuery in search package be deprecated and like for the other queries now create a factory only. Maybe just have a public subclass in the serach package. I will think a bit about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
