rmuir opened a new pull request, #12128:
URL: https://github.com/apache/lucene/pull/12128

   LongHashSet is used for the set of numbers, but it has some issues:
   * tries too hard to extend AbstractSet, mostly for testing
   * causes traps with boxing if you aren't careful
   * complex hashcode/equals
   
   Practically we should take advantage of the fact numbers come in sorted 
order for multivalued fields: just like range queries do. So we use min/max to 
our advantage, including termination of docvalues iteration.
   
   Actually it is generally a win to just check min/max even in the 
single-valued case: these constant time comparisons are cheap and can avoid 
hashing, etc.
   
   In the worst-case, if all of your query Sets contain both the minimum and 
maximum possible values, then it won't help, but it doesn't hurt either.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to