rmuir commented on PR #12089: URL: https://github.com/apache/lucene/pull/12089#issuecomment-1416779603
Hmm, @gsmiller I really personally don't like all this complexity and optimizations mixed into `TermInSetQuery`. It becomes almost unmanageable. This is why I like the IndexOrDocValues approach: we can have two simple queries instead of one extremely complicated one. If it is a must that we create a giant HeroicTermInSetQuery that tries to do anything and everything, then let's name it just that: also make it package private in `org.apache.lucene.document`, it can be hooked in by KeywordField. But I'd really like us to consider the cost in the complexity here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
